Skip to content

refactor: remove registerEvents function #10877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2025

Conversation

sdanialraza
Copy link
Member

@sdanialraza sdanialraza commented May 3, 2025

Please describe the changes this PR makes and why it should be merged:
Removes the registerEvents util function:

  • Moved the interactionCreate event to the events folder, the commands loading is also done there now
  • Moved loading event handlers to index
  • Wrap event.execute in a try-catch

Internal Discussion

Copy link

vercel bot commented May 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 11, 2025 11:57am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 11, 2025 11:57am

almeidx
almeidx previously requested changes May 3, 2025
@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js May 3, 2025
@sdanialraza sdanialraza requested a review from almeidx May 3, 2025 17:53
@sdanialraza sdanialraza force-pushed the refactor/remove-register-events-function branch from f1addeb to 42c0103 Compare May 5, 2025 20:16
@sdanialraza sdanialraza requested a review from Qjuh May 5, 2025 20:17
@sdanialraza sdanialraza force-pushed the refactor/remove-register-events-function branch from 42c0103 to fcd1f00 Compare May 6, 2025 15:29
@sdanialraza sdanialraza requested a review from Qjuh May 6, 2025 15:30
@sdanialraza sdanialraza force-pushed the refactor/remove-register-events-function branch from fcd1f00 to 85d1e54 Compare May 7, 2025 11:27
@sdanialraza sdanialraza requested a review from Jiralite May 7, 2025 11:28
@sdanialraza sdanialraza requested a review from vladfrangu May 10, 2025 20:32
@sdanialraza sdanialraza force-pushed the refactor/remove-register-events-function branch from b454a19 to acd6bd2 Compare May 11, 2025 11:57
@sdanialraza sdanialraza requested a review from didinele May 11, 2025 11:58
@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js May 11, 2025
@kodiakhq kodiakhq bot merged commit 2c21de6 into main May 11, 2025
8 checks passed
@kodiakhq kodiakhq bot deleted the refactor/remove-register-events-function branch May 11, 2025 12:21
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants